gabriel / musehub public
Open
aaronrene aaronrene · 7 hours ago · 1 agent

fix: proposal and issue pages scroll with the window

Summary

Proposal #12 and issue pages look frozen because the window is locked. Only a short inner box scrolls, and on a long proposal that box sits at the bottom where the mouse rarely lands.

This drops that lock on the proposal detail page and the issue detail page. The page itself scrolls. Wide screens use a 3/4 + 1/4 grid. Narrow screens stack to one column. Other pages keep the old locked layout.

The console message about a blocked inline script is unchanged and is not this bug. Script rules were not loosened.

Check

  • Branch feat/detail-page-document-scroll → dev
  • Tip sha256:835ed2eec931dc5f65fc2bd438a80162698a784e0a6f2e3bcf885ea9fa9b3b58
  • tests/test_detail_page_document_scroll.py — 9 passed locally
  • CSS is compiled at deploy (npm run build) because app.css is not in the snapshot

Please review before any staging or production deploy.

feat/detail-page-document-scroll dev branch
high risk
minor semver
0/2 approvals
merge type
sha256:835ed2eec931dc5f65fc2bd438a80162698a784e0a6f2e3bcf885ea9fa9b3b58 from
sha256:95c1e74446fa16e9155eac4d5ded6fcfc9df130916d4dc84b53a98097fb96575 to

Symbol Delta

29 symbols
23 added 6 modified
musehub/templates/musehub/pages/proposal_detail.html 6
~ aside@565 breaking
~ section@241 breaking
~ section@331 breaking
~ section@363 breaking
~ section@400 breaking
~ section@450 breaking
tests/test_detail_page_document_scroll.py 23
+ APP_CSS
+ ISSUES_SCSS
+ ISSUE_HTML
+ ISSUE_LIST_HTML
+ MAIN_PY
+ PROPOSAL_HTML
+ PROPOSAL_SCSS
+ ROOT
+ _GRID
+ _NARROW
+ _block
+ import::Path
+ import::annotations
+ import::re
+ test_tier1_issue_list_stays_on_app_shell
+ test_tier1_templates_do_not_opt_into_app_shell
+ test_tier2_columns_are_three_quarters_and_one_quarter
+ test_tier2_detail_columns_do_not_scroll_themselves
+ test_tier3_compiled_css_matches_the_grid
+ test_tier4_narrow_breakpoint_is_present_for_both_pages
+ test_tier5_page_wrappers_are_not_height_locked
+ test_tier6_compiled_stylesheet_stays_a_single_file
+ test_tier7_csp_still_blocks_inline_scripts

Files Changed

13 of 1,076
A tests/test_detail_page_document_scroll.py
M .museagent.md
M docs/deploy.md
M docs/roadmaps/orgs.md
M musehub/services/musehub_wire_push.py
M musehub/templates/musehub/pages/docs_muse_identity.html
M musehub/templates/musehub/pages/issue_detail.html
M musehub/templates/musehub/pages/proposal_detail.html
M src/scss/pages/_issues.scss
M src/scss/pages/_proposal-detail.scss
D docs/issues/issue-223-key-status-endpoint-missing.md
D docs/issues/issue-224-user-identity-admin-crud-gap.md
D tests/test_wire_push_root_snapshot_integrity.py

Commits

1
fix agent
fix: let proposal and issue pages scroll as a page Drop the locked window on those...
aaronrene · 7 hours ago
minor sha256:835ed2eec931

Divergence Analysis

feat/detail-page-document-scroll → dev
0%
0% divergence
Very compatible — minimal differences

Review comments

0

No review comments yet

Be the first to leave a review comment on this merge proposal.

Muse CLI

Comment muse hub proposal comment create sha256:0a880db4a44be02dc5d7ac3061eaa34b6f5b302ad6dc2e126f36cf00f1c83410 --body "…"
Approve muse hub proposal review submit sha256:0a880db4a44be02dc5d7ac3061eaa34b6f5b302ad6dc2e126f36cf00f1c83410 --verdict approve
Request changes muse hub proposal review submit sha256:0a880db4a44be02dc5d7ac3061eaa34b6f5b302ad6dc2e126f36cf00f1c83410 --verdict request_changes --body "…"
Close muse hub proposal close sha256:0a880db4a44be02dc5d7ac3061eaa34b6f5b302ad6dc2e126f36cf00f1c83410
Merge — merge engine docs ↗
Merge muse hub proposal merge sha256:0a880db4a44be02dc5d7ac3061eaa34b6f5b302ad6dc2e126f36cf00f1c83410 --hub http://staging.musehub.ai