Closed #82

filed by gabriel human · 4 days ago

Merge proposal docs link returns 404

0 Anchors

— Blast radius

— Churn 30d

0 Proposals

Fix Broken Docs Link in Merge Proposal CLI Section

Current Behavior

The "Muse CLI" section of every open merge proposal shows a docs ↗ link that returns a 404. The browser console shows:

Response Status Error Code 404 from /docs/merging

The link is hardcoded in the proposal detail template:

musehub/templates/musehub/pages/proposal_detail.html line 553

· <a class="proposal-cli-ref-docs" href="/docs/merging">docs ↗</a>

The route /docs/merging does not exist. All docs routes are registered under /muse/<slug> (e.g., /muse/wire, /muse/foundations) via musehub/api/routes/musehub/ui_docs.py. There is no merging slug in _PHASES and no route handler for /docs/merging or /muse/merging.

Fix Options

Option A — Quick fix: update the href to the closest existing page. /muse/wire covers the push/fetch protocol that drives merges. Not perfect but stops the 404 immediately.

Option B — Proper fix: add a merging entry to _PHASES in ui_docs.py, add a GET /muse/merging route handler, create musehub/templates/musehub/pages/docs_muse_merging.html, and update the href to /muse/merging. The page should document --strategy (overlay, weave, replay) and --history (merge, squash, rebase) — the same flags already explained in the tooltip at line 550.

Option B is the right call: the tooltip text at line 550 already has the content outline. The docs page just needs to expand it.

Relevant Code

File	Location	Notes
`musehub/templates/musehub/pages/proposal_detail.html`	line 553	broken `href="/docs/merging"`
`musehub/api/routes/musehub/ui_docs.py`	`_PHASES` list + route handlers	where the new slug and route go
`musehub/templates/musehub/pages/`	`docs_muse_*.html`	template naming convention

Acceptance Criteria

docs ↗ on a merge proposal detail page no longer returns 404
The link destination documents --strategy and --history flag semantics
New /muse/merging slug appears in the docs index (/muse) alongside the other phases
ui_docs.py _PHASES entry added so the sidebar renders the page in context

◎ Activity1

●

gabriel opened this issue 4 days ago

○

gabriel 3 days ago

Resolved as part of the #83 fix (deployed today). The broken /docs/merging link in the proposal CLI section was replaced with /muse/merge — the merge engine docs page that was built out earlier this sprint. That page covers strategies (overlay, weave, replay), history modes (merge, squash, rebase), Harmony conflict resolution, and the safe merge protocol. No 404 and no stub page needed.

✓

closed this issue 3 days ago

Assignee

gabriel human

Release

no commits linked to this issue

create

muse hub issue create \
  --title "..." \
  --body "..." \
  --label bug \
  --anchor path/to/file.py::Symbol \
  --commit-anchor <sha> \
  --repo gabriel/musehub

read

muse hub issue get 82 --json
muse hub issue list --state open --json

update

muse hub issue edit 82 \
  --anchor path/to/file.py::Symbol \
  --repo gabriel/musehub

comment

muse hub issue comment 82 \
  --body "Fixed in <sha>" \
  --repo gabriel/musehub

reopen

muse hub issue reopen 82 \
  --repo gabriel/musehub

create

create_issue({
  repo_id: "sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75",
  title: "...",
  body: "...",
  labels: ["bug"],
  symbol_anchors: [
    "path/to/file.py::Symbol"
  ],
  commit_anchors: ["<sha>"]
})

read

get_issue({
  repo_id: "sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75",
  issue_number: 82
})

list_issues({
  repo_id: "sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75",
  state: "open"
})

update

edit_issue({
  repo_id: "sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75",
  issue_number: 82,
  symbol_anchors: ["path/to/file.py::Symbol"]
})

comment

create_issue_comment({
  repo_id: "sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75",
  issue_number: 82,
  body: "..."
})

reopen

reopen_issue({
  repo_id: "sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75",
  issue_number: 82
})

create

curl -X POST \
  http://localhost:10003/api/repos/sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75/issues \
  -H "Content-Type: application/json" \
  -H "Authorization: MSign handle=\"...\" ts=... sig=\"...\"" \
  -d '{
    "title": "...",
    "body": "...",
    "labels": ["bug"],
    "symbol_anchors": ["path/to/file.py::Symbol"]
  }'

read

# get one issue
curl http://localhost:10003/api/repos/sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75/issues/82

# list open issues
curl "http://localhost:10003/api/repos/sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75/issues?state=open"

update

curl -X PATCH \
  http://localhost:10003/api/repos/sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75/issues/82 \
  -H "Content-Type: application/json" \
  -H "Authorization: MSign handle=\"...\" ts=... sig=\"...\"" \
  -d '{"title": "...", "body": "..."}'

comment

curl -X POST \
  http://localhost:10003/api/repos/sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75/issues/82/comments \
  -H "Content-Type: application/json" \
  -H "Authorization: MSign handle=\"...\" ts=... sig=\"...\"" \
  -d '{"body": "Fixed in <sha>"}'

reopen

curl -X POST \
  http://localhost:10003/api/repos/sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75/issues/82/reopen \
  -H "Authorization: MSign handle=\"...\" ts=... sig=\"...\""