Production readiness — Section 14: Application Security

0 Anchors

— Blast radius

— Churn 30d

0 Proposals

Confirmed strong existing posture: no SQL injection surface (parameterized queries throughout), path traversal and zip-bomb protection already implemented, MSign requires fresh signatures for privileged actions, CORS fails closed, thorough upload/quota limits.

Fixed this session: the /_debug/memory endpoint was exposed unconditionally in production (missing the same settings.debug guard /docs and /redoc correctly have) — patched.

Remaining: CSRF review, WebSocket/SSE auth review, SSRF review of musehub/worker.py specifically, data classification/retention docs, formal OWASP-oriented pass before launch.

◎ Activity1

●

gabriel opened this issue 68 days ago

○

gabriel 38 days ago

Reviewed every remaining gap with real code inspection, not just assumptions.

Resolved:

SSRF protection confirmed real and actually wired in — musehub/security/ssrf.py (two-layer: sync field validation + async DNS-rebinding check), enforced in both musehub/models/musehub.py and the webhook dispatcher. (The original doc guessed this lived in worker.py — it doesn't; that's the unrelated background job processor.)
CSRF confirmed genuinely N/A — zero cookie-setting code anywhere in the codebase.
MCP/SSE authentication confirmed correct — same MSign mechanism throughout (TokenClaims/optional_token are just re-exported aliases for the real implementation), optional at connection level, enforced per-privileged-action.
Account/data deletion mechanism confirmed to exist (soft-delete via deleted_at).

Real finding: MSign's per-request signing (request_signing.py) only enforces a 30-second freshness window — it does not track or reject a duplicate (handle, ts, sig) replayed within that window. No nonce/dedup exists for it, unlike the codebase's own auth-challenge and MPay flows which do have single-use nonces. Corrected the docstring's overstated "replay protection" claim to describe what it actually does. Practical severity is real but narrow (needs an attacker to capture a signed request within 30s, and a non-idempotent action to matter).

Split remaining work (build the actual dedup fix, content scanning, retention policy, formal OWASP pass) to #178.

Closing.

✓

closed this issue 38 days ago

Assignee

gabriel human

Release

no commits linked to this issue

create

muse hub issue create \
  --title "..." \
  --body "..." \
  --label bug \
  --anchor path/to/file.py::Symbol \
  --commit-anchor <sha> \
  --repo gabriel/musehub

read

muse hub issue get 162 --json
muse hub issue list --state open --json

update

muse hub issue edit 162 \
  --anchor path/to/file.py::Symbol \
  --repo gabriel/musehub

comment

muse hub issue comment 162 \
  --body "Fixed in <sha>" \
  --repo gabriel/musehub

reopen

muse hub issue reopen 162 \
  --repo gabriel/musehub

create

create_issue({
  repo_id: "sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75",
  title: "...",
  body: "...",
  labels: ["bug"],
  symbol_anchors: [
    "path/to/file.py::Symbol"
  ],
  commit_anchors: ["<sha>"]
})

read

get_issue({
  repo_id: "sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75",
  issue_number: 162
})

list_issues({
  repo_id: "sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75",
  state: "open"
})

update

edit_issue({
  repo_id: "sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75",
  issue_number: 162,
  symbol_anchors: ["path/to/file.py::Symbol"]
})

comment

create_issue_comment({
  repo_id: "sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75",
  issue_number: 162,
  body: "..."
})

reopen

reopen_issue({
  repo_id: "sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75",
  issue_number: 162
})

create

curl -X POST \
  http://localhost:10003/api/repos/sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75/issues \
  -H "Content-Type: application/json" \
  -H "Authorization: MSign handle=\"...\" ts=... sig=\"...\"" \
  -d '{
    "title": "...",
    "body": "...",
    "labels": ["bug"],
    "symbol_anchors": ["path/to/file.py::Symbol"]
  }'

read

# get one issue
curl http://localhost:10003/api/repos/sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75/issues/162

# list open issues
curl "http://localhost:10003/api/repos/sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75/issues?state=open"

update

curl -X PATCH \
  http://localhost:10003/api/repos/sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75/issues/162 \
  -H "Content-Type: application/json" \
  -H "Authorization: MSign handle=\"...\" ts=... sig=\"...\"" \
  -d '{"title": "...", "body": "..."}'

comment

curl -X POST \
  http://localhost:10003/api/repos/sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75/issues/162/comments \
  -H "Content-Type: application/json" \
  -H "Authorization: MSign handle=\"...\" ts=... sig=\"...\"" \
  -d '{"body": "Fixed in <sha>"}'

reopen

curl -X POST \
  http://localhost:10003/api/repos/sha256:a265796360c3b1b8700b5682ced5f6b044a2c0d3a2c58918892a5aa494db6c75/issues/162/reopen \
  -H "Authorization: MSign handle=\"...\" ts=... sig=\"...\""