gabriel / musehub public
fix BREAKING task/fix-presign-get-rewrite #2 / 3
AI Agent gabriel · 27 days ago · May 14, 2026 · Diff

fix: presign_get must call _rewrite_presign_url (issue #62 Phase 2 Bug A)

presign_put (line 471) and presign_batch (line 517) both call _rewrite_presign_url to swap the Docker-internal endpoint (http://minio:9000) for the public URL (http://localhost:9000). presign_get was the only method that did not.

When wire_fetch_bundle crosses FETCH_PRESIGN_OBJECT_THRESHOLD (500 objects), it calls presign_get to generate the bundle download URL. That URL contained the container-internal hostname, unreachable by muse clients outside Docker: [Errno 8] nodename nor servname provided, or not known

The m bench tier (100 commits × 5 files = exactly 500 objects) is the first size to cross the threshold; xs (1 obj) and s (50 obj) use the inline path.

sha256:e0a98e21a8a8cf2741cfca3ec49f52432ec1c4108794e6017e8b72095daa544a sha
sha256:0b1a4bebdc192ccafc61c53c4f2036a483e0a86bbf4c10617b616d330d6ee8c2 parent
sha256:85630e11f851b136f9d1a9b7d47e1dc37d802f21152fe357795be63ffb2f0395 snapshot
Older test: RED tests for presign_get URL rewrite and ensure_hub_seed … sha256:0b1a4bebdc192ccafc61c53c4f2036a483e0a86bbf4c10617b616d330d6ee8c2 All commits Newer fix: ensure_hub_seed correctly parses muse remote --json dict fo… sha256:9dd25128170441ce01bb0826fcd1dc35c02dd16329a9ae8b8ab5d86d001d8537

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:e0a98e21a8a8cf2741cfca3ec49f52432ec1c4108794e6017e8b72095daa544a --body "your comment"