fix
patch
task/tdd-wire-fetch-merge-snapshot
#1 / 1
fix: wire_fetch_mpack falls back to MusehubCommit.snapshot_id when CommitGraph has NULL
Server-side merge commits created before the proposals fix had CommitGraph rows with snapshot_id=NULL. wire_fetch_mpack was building snap_ids exclusively from CommitGraph rows, so those commits returned snaps=0 in the fetch response.
MusehubCommit always has the correct snapshot_id. Merge both sources so the fetch is resilient whether CommitGraph is populated or not.
Tests FB6 and FB7 added: FB6 covers the NULL-CommitGraph fallback path, FB7 covers the happy path where CommitGraph has snapshot_id set.
sha256:a68b91a9b1f1705e66730a0c328710192bc5e921c829892f0f9a11678341e148
sha
+2
~1
symbols
sha256:2bfc41f59ab6faaf2a8c8d4018acfa8043977ca5876fcaf6d1b1994ee3d5a8d0
snapshot
+2
symbols added
~1
symbol modified
0
dead code introduced
Semantic Changes
3 symbols
+
.vscode/
+
alembic/
+
deploy/
+
docs/
+
musehub/
+
scripts/
+
src/
+
src/ts/
+
tests/
+
tools/
+
test_fb6_merge_commit_snapshot_included_via_commit_fallback
function
async_function test_fb6_merge_commit_snapshot_included_via_commit_fallback L412–508
+
test_fb7_merge_commit_snapshot_included_via_commit_graph
function
async_function test_fb7_merge_commit_snapshot_included_via_commit_graph L517–604
← Older
Oldest on task/tdd-wire-fetch-merge-snapshot
All commits
Newer →
Latest on task/tdd-wire-fetch-merge-snapshot
0 comments
To add a comment, use the Muse CLI:
muse hub commit comment sha256:a68b91a9b1f1705e66730a0c328710192bc5e921c829892f0f9a11678341e148 --body "your comment"
No comments yet. Be the first to start the discussion.