gabriel / musehub public
fix patch dev #8 / 100
AI Agent gabriel · 1 day ago · Jun 11, 2026 · Diff

fix: fast-forward push validation falls back to DB ancestor walk

_is_fast_forward only traverses commits in the mpack. When a branch tip's parent chain includes commits already on the server under a different branch, the pack is minimal and the sync traversal can't reach current_head. Result: valid fast-forward pushes rejected as diverged.

Fix: after the pack traversal fails, fall back to _is_ancestor_db to check the full commit graph stored in the DB before rejecting.

sha256:a1d7cf2d9e9c9f4edc566e56afbde3f6b3194ca712209beb02eb3c838d1f47e6 sha
sha256:bb4fd86fb8c079ac23e95d87a38f85abe2c65f616d91717fb64350b5c8df4e43 parent
+1 ~15 symbols
sha256:a54119a93d38c754d87ecb73028ee702cdf4a466252b062c63c1d342e7349ee2 snapshot
+1
symbol added
~15
symbols modified
0
dead code introduced
Semantic Changes 16 symbols
~ musehub/services/musehub_wire_push.py .py 1 symbol added, 15 symbols modified
+ _is_ancestor_db import import _is_ancestor_db L40–40
~ MPackValidationError
~ NonFastForwardError
~ ObjectHashMismatch
~ RepairResult
~ _ChildMap
~ _int_safe
~ _is_fast_forward
~ _parse_iso
~ _reconstruct_manifest
~ _str_list
~ _to_wire_commit
~ _upsert_object_refs
~ _utc_now
~ logger
~ wire_push_unpack_mpack
Older Merge staging/dev into dev sha256:bb4fd86fb8c079ac23e95d87a38f85abe2c65f616d91717fb64350b5c8df4e43 All commits Newer revert: undo unauthorized wire protocol change sha256:1c94edd45e7ed3bf7012c2742e755bb7608890f0964aa2ba9ea7f8cf83807013

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:a1d7cf2d9e9c9f4edc566e56afbde3f6b3194ca712209beb02eb3c838d1f47e6 --body "your comment"