fix: sha256:281d7e2bfa6d4378354b0287c78e3bf1902581c486d072d3352c9d645ba81f63 · gabriel/musehub

fix(musehub#134): reconstruct external delta-only parent instead of {}

wire_push_unpack_mpack's external-parent resolution only checked manifest_blob directly. When a pushed snapshot's parent was already on the server from an earlier push and stored delta-only (the normal case for any non-root/non-head snapshot), the lookup silently fell back to an empty dict, and the child's manifest permanently dropped every inherited file -- content that can never hash back to its own snapshot_id again. This is the root cause of the staging gabriel/musehub clone corruption blocking aaronrene (musehub#84) and matching the pattern in muse#35.

Two-part fix: 1. When the direct manifest_blob lookup misses, fall back to _reconstruct_manifest_validated (delta-chain walk) instead of {}. 2. Hash-verify every resolved snapshot base against its own snapshot_id before writing. A parent that is genuinely unrecoverable (e.g. a phantom reference with no backing row at all -- confirmed on the real staging RDS instance) now rejects the push loudly instead of silently persisting a manifest that will never verify again.

TDD: tests/test_wire_push_external_parent_reconstruction.py, 2 tests, red-first. Calls wire_push_unpack_mpack directly with a hand-built payload -- the only reliable way to force the external-parent path, since muse push's have-negotiation (literal branch-tip match, no ancestor-closure expansion) makes a CLI-level integration test resend the whole chain, masking the bug (see test_push_delta_only_parent_manifest.py, which passes without exercising it).

Full wire-push regression sweep: 211 passed (42 direct + 169 broader mpack/ push/intel suite).

symbols added

~18

symbols modified

dead code introduced

Semantic Changes 21 symbols

~ musehub/services/musehub_wire_push.py .py 2 symbols added, 18 symbols modified

+ _reconstruct_manifest_validated import import _reconstruct_manifest_validated L42–42

+ hash_snapshot import import hash_snapshot L34–34

~ MPackValidationError

~ NonFastForwardError

~ ObjectHashMismatch

~ RepairResult

~ _ChildMap

~ _commit_identity_bytes

~ _int_safe

~ _is_ancestor_db

~ _is_fast_forward

~ _parse_iso

~ _reconstruct_manifest

~ _str_list

~ _to_wire_commit

~ _upsert_object_refs

~ _utc_now

~ logger

~ long_id

~ wire_push_unpack_mpack

~ tests/test_wire_push_external_parent_reconstruction.py .py 1 symbol added

+ test_push_rejected_when_external_parent_is_a_total_phantom function async_function test_push_rejected_when_external_parent_is_a_total_phantom L238–295

Older test(red): musehub#134 — push must reconstruct external delta-on… sha256:b916bfaf72c56574764215fb36e245869f2cf36c7fab7e38afbc195d8d105a54 All commits Newer docs: fix stale bare-hex claim in repair-object/repair-snapshot … sha256:09bfcf29fa75b8c59d1c3bdba789cebc6ee19c2e3b7b238539ea08f78c7adfd4

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:281d7e2bfa6d4378354b0287c78e3bf1902581c486d072d3352c9d645ba81f63 --body "your comment"