gabriel / musehub public
test mwp6/phase2 task/mwp-6-phase2 #1 / 1
AI Agent gabriel · 21 days ago · Jun 29, 2026 · Diff

test(mwp6/phase2): delete test_mpack_phase3.py, delete PF-4 (MWP6_20..23)

MWP6_20 — shipped contract confirmed: wire_push_unpack_mpack calls enqueue_push_intel (step 11, push.py:1071) which calls enqueue_job → enqueues mpack.index as a background job. issue-#69 'fully synchronous, no job' is abandoned in the shipped design.

MWP6_21 — DELETE tests/test_mpack_phase3.py: P3-1 asserts 'no mpack.index job must be enqueued after push' — directly contradicts enqueue_push_intel at step 11. All three P3 tests are testing an abandoned synchronous-push design (issue-#69). Deleted with muse rm.

MWP6_22 — test_mpack_push_async.py: REVIVE (Phase 5 target): Core asserts (commits_written, snapshots_written, branch_heads) match the current contract. BUT the test requires live MinIO: _upload_mpack does a real PUT to a presigned URL; cannot run in-process. Decision: REVIVE in Phase 5 alongside clone/fetch xs unit (live E2E); replace flux skip with infra guard then. No changes to the file in Phase 2. Exactly one of phase3/push_async survives — push_async lives, phase3 dies.

MWP6_23 — DELETE PF-4 from tests/test_mpack_fetch_phase3.py: PF-4 tests 'falls back to inline bytes when mpack index empty'. The inline-bytes return path is gone: current wire_fetch_mpack with have=[] raises MPackNotReadyError on cache miss; with have set, always assembles a new mpack + returns presigned mpack_url — never mpack_bytes or a distinct presigned_url key. PF-4's assertions (mpack_fetch, mpack_bytes, presigned_url) all fail against the current return shape. PF-4 deleted; PF-1..3 kept for Phase 4 revival. Removed orphaned _Base import + session_add_all helper + PF-4 docstring.

Issue: musehub#110, master: muse#58

sha256:185aa901c896f5c5a14020fb4eca020266791005108c15882aedb43f7e6fe9e1 sha
sha256:6a512979e6e9656d71f6ac64c5d3addc753074f0ac52b1af29b6a1bd9e11d307 parent
−40 symbols
sha256:a9cfc6a17f9bf52fc3c50cbba54315d57ab6b52af3640d58aebaeac0a71fe4a8 snapshot
−40
symbols removed
0
dead code introduced
Semantic Changes 40 symbols
~ tests/test_mpack_phase3.py .py 37 symbols removed
− _FakeBackend class class _FakeBackend L65–105
− __init__ method method __init__ L68–71
− delete method async_method delete L90–91
− exists method async_method exists L87–88
− get method async_method get L78–79
− get_mpack method async_method get_mpack L81–82
− presign_get method async_method presign_get L93–94
− presign_mpack_get method async_method presign_mpack_get L96–97
− put method async_method put L73–76
− put_mpack method async_method put_mpack L84–85
− quarantine_mpack method async_method quarantine_mpack L99–100
− uri_for method method uri_for L102–103
− _build_push_mpack function function _build_push_mpack L52–62
− _mpack_id function function _mpack_id L48–49
− _now function function _now L44–45
− AsyncSession import import AsyncSession L31–31
− Mapping import import Mapping L22–22
− MusehubBackgroundJob import import MusehubBackgroundJob L36–36
− annotations import import annotations L19–19
− blob_id import import blob_id L34–34
− create_repo import import create_repo L41–41
− datetime import import datetime L23–23
− db import import db L35–35
− fake_id import import fake_id L34–34
− hashlib import import hashlib L21–21
− msgpack import import msgpack L25–25
− pg_insert import import pg_insert L30–30
− pytest import import pytest L26–26
− select import import select L32–32
− timezone import import timezone L23–23
− wire_fetch_mpack import import wire_fetch_mpack L37–37
− wire_push_unpack_mpack import import wire_push_unpack_mpack L37–37
− zstandard import import zstandard L27–27
− pytestmark variable variable pytestmark L29–29
− test_p3_1_no_mpack_index_job_enqueued function async_function test_p3_1_no_mpack_index_job_enqueued L111–146
− test_p3_2_storage_uri_is_mpack_uri_after_push function async_function test_p3_2_storage_uri_is_mpack_uri_after_push L152–187
− test_p3_3_immediate_fetch_after_push function async_function test_p3_3_immediate_fetch_after_push L193–286
~ tests/test_mpack_fetch_phase3.py .py 3 symbols removed
− _Base import import _Base L31–31
− session_add_all function async_function session_add_all L355–357
− test_pf4_fallback_to_inline_when_no_mpack_index function async_function test_pf4_fallback_to_inline_when_no_mpack_index L272–352
← Older Oldest on task/mwp-6-phase2
All commits
Newer → Latest on task/mwp-6-phase2

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:185aa901c896f5c5a14020fb4eca020266791005108c15882aedb43f7e6fe9e1 --body "your comment"