gabriel / muse public
fix patch fix/hub-release-list-params-crash #1 / 1
AI Agent gabriel · 1 day ago · Sep 10, 2026 · Diff

fix: muse hub release list crashed on every call (_hub_api has no params kwarg)

run_release_list called _hub_api(..., params=params) but _hub_api's actual signature is (hub_url, identity, method, path, body=None, timeout=10.0) — no params kwarg exists at all. Every invocation crashed with a TypeError before making any request. Completely untested until now (found while confirming build/version state ahead of cutting a release for #185).

Fixed to match the established pattern used elsewhere (e.g. run_issue_list): urlencode the query params directly into the path string, since _hub_api has no separate params argument.

3 tests added (previously zero coverage for this command), written first against the real crash. Verified live against staging and production hubs — muse hub release list --json now returns real data instead of crashing.

sha256:c4f1efcedc75c6d1eda18b7f73bbe06081120c20afd3aa3eb688a63cc22389c7 sha
sha256:2a8dfcf895b528326eedf00a21babac1a18d90176b856ea1e0fb3027b39be0da parent
+10 ~1 symbols
2 changed · 1164 in snapshot files
sha256:e26044946246afc34eb08674dba43d691863939192bb7a2295e4260b326cc747 snapshot
+10
symbols added
~1
symbol modified
2
files changed
1164
files in snapshot
0
dead code introduced
Semantic Changes 11 symbols
~ tests/test_cmd_hub_release_list.py .py 9 symbols added
+ TestRunReleaseList class class TestRunReleaseList L20–82
+ test_json_output_includes_releases_from_response method method test_json_output_includes_releases_from_response L65–82
+ test_limit_and_cursor_reach_the_request_url_as_query_params method method test_limit_and_cursor_reach_the_request_url_as_query_params L21–42
+ test_no_cursor_omits_cursor_param method method test_no_cursor_omits_cursor_param L44–63
+ _FakeIdentity class class _FakeIdentity L16–17
+ argparse import import argparse L8–8
+ json import import json L9–9
+ pytest import import pytest L11–11
+ releases_mod import import releases_mod L13–13
~ muse/cli/commands/hub/releases.py .py 1 symbol added, 1 symbol modified
+ parse import import urllib.parse L2–2
~ run_release_list
Files Changed
+1 ~1
1164 in snapshot
+ tests/test_cmd_hub_release_list.py .py
~ muse/cli/commands/hub/releases.py .py
← Older Oldest on fix/hub-release-list-params-crash
All commits
Newer → Latest on fix/hub-release-list-params-crash

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:c4f1efcedc75c6d1eda18b7f73bbe06081120c20afd3aa3eb688a63cc22389c7 --body "your comment"