fix: sha256:700e5e8a55f5913738576608e502b8c00c60cb76819a7086dfac2b8d5afc919b · gabriel/muse

fix: muse domains publish/update/delete never worked against localhost HTTPS

Discovered while debugging gabriel's report of /domains showing 0 repos on staging: registering the same domains locally to reproduce and debug before deploying to staging surfaced that `muse domains publish` fails outright against https://localhost:1337 with a certificate verify error.

_post_json/_patch_json/_delete_request called urllib.request.urlopen() with no SSL context, always falling back to the default system CA bundle — which doesn't trust mkcert's local root CA. Every other network command in this codebase (push, pull, clone) already goes through transport.py::_make_ssl_ctx() for exactly this reason; domains.py's HTTP helpers were written independently and never picked up that pattern.

- Added `context=_make_ssl_ctx(url)` to all three urlopen() calls in domains.py. urlopen() accepts context= directly, so no call-shape change was needed — existing tests mocking urllib.request.urlopen keep working once their fake functions accept the new kwarg. - _make_ssl_ctx() itself now memoizes both the localhost (mkcert CA) and default context process-wide — a real, measured cost (500 sequential calls went from <2.0s to 2.14s) from recreating create_default_context() and shelling out to `mkcert -CAROOT` on every single call, with zero per-call variance to justify not caching. - Updated ~20 test mock signatures across three test files (test_domains_publish.py, test_stress_domains_publish.py, test_cmd_domains_hardening.py) that hardcoded a narrow (req, timeout) signature not accepting the new context kwarg.

Verified live: `muse domains publish --hub https://localhost:1337` now succeeds. 315/315 tests pass (domains CLI suite + core transport suite), zero regressions, zero new mypy errors (confirmed against baseline for both modified files).

symbols added

~29

symbols modified

files changed

1120

files in snapshot

dead code introduced

Semantic Changes 31 symbols

~ muse/cli/commands/domains.py .py 3 symbols modified

~ _delete_request

~ _patch_json

~ _post_json

~ muse/core/transport.py .py 2 symbols added, 1 symbol modified

+ _default_ssl_ctx variable variable _default_ssl_ctx L147–147

+ _localhost_ssl_ctx variable variable _localhost_ssl_ctx L148–148

~ _make_ssl_ctx

~ tests/test_cmd_domains_hardening.py .py 7 symbols modified

~ TestDomainsSecurity

~ test_server_ansi_in_scoped_id_sanitized

~ TestPostJson

~ test_correct_method_and_headers

~ test_missing_keys_normalised_to_empty_string

~ test_non_object_json_raises_value_error

~ test_response_size_cap_applied

~ tests/test_domains_publish.py .py 2 symbols modified

~ test_post_json_sends_correct_request

~ test_publish_custom_version

~ tests/test_stress_domains_publish.py .py 16 symbols modified

~ TestPublishExtended

~ test_capabilities_dimensions_parsed_correctly

~ test_default_version_is_0_1_0

~ test_display_name_propagated_as_display_name

~ test_version_flag_propagated

~ TestPublishStress

~ test_large_description_10000_chars_transmitted

~ test_cli_publish_hub_url_propagated

~ test_cli_publish_large_description

~ test_cli_publish_slug_with_hyphens

~ test_cli_publish_version_semver

~ test_e2e_publish_capabilities_auto_from_code_plugin

~ test_e2e_publish_complete_payload_structure

~ test_post_json_concurrent_thread_safety

~ test_post_json_large_capabilities

~ test_post_json_unicode_description

Files Changed

1120 in snapshot

~ muse/cli/commands/domains.py .py

~ muse/core/transport.py .py

~ tests/test_cmd_domains_hardening.py .py

~ tests/test_domains_publish.py .py

~ tests/test_stress_domains_publish.py .py

← Older Oldest on fix/domains-cli-localhost-tls

All commits

Newer → Latest on fix/domains-cli-localhost-tls

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:700e5e8a55f5913738576608e502b8c00c60cb76819a7086dfac2b8d5afc919b --body "your comment"