gabriel / muse public
refactor BREAKING phase1 task/phase1-from-dict-rename #1 / 1
AI Agent gabriel · 20 days ago · May 21, 2026 · Diff

refactor(phase1): rename from_msgpack → from_dict on all storage record classes

- CommitRecord, SnapshotRecord, TagRecord, ReleaseRecord: merged the two-method pattern (defensive from_msgpack + trusting from_dict) into a single from_dict that uses the defensive body. Deleted from_msgpack. - SymbolHistoryEntry: same merge; from_msgpack deleted, from_dict rewritten with defensive .get() pattern. - muse/core/test_history.py: _record_from_msgpack → _record_from_dict, _record_to_msgpack → _record_to_dict. - Updated all 9 source call sites and all test files that referenced from_msgpack or the private helpers. - Added tests/test_phase1_naming.py: 21 TDD tests that enforce no from_msgpack method exists anywhere and no .from_msgpack( call remains in source or test files.

Closes issue #12 phase 1 (naming fix).

sha256:2d04edd1c8bae30686ae49061151b3f3ddb98d48136d76cde3af696a03e9b33e sha
sha256:43b516a70ad066d2dca6fd627c3b52510283d4d1e960523416124b6aaeb9806b parent
12 changed · 1045 in snapshot files
sha256:a017004c83dcd76cd394d32588b9f28988b712b486e4aea43f241ab14928f280 snapshot
12
files changed
1045
files in snapshot
Files Changed
+1 ~11
1045 in snapshot
+ tests/test_phase1_naming.py .py
~ muse/core/indices.py .py
~ muse/core/store.py .py
~ muse/core/test_history.py .py
~ tests/test_cmd_snapshot_hardening.py .py
~ tests/test_commit_from_dict_timestamp_loss.py .py
~ tests/test_commit_record_committed_at_corruption.py .py
~ tests/test_commit_record_schema.py .py
~ tests/test_core_test_history.py .py
~ tests/test_directories_feature.py .py
~ tests/test_phase7_bundle_atomicity.py .py
~ tests/test_snapshot_schema_version_and_compression.py .py
← Older Oldest on task/phase1-from-dict-rename
All commits
Newer → Latest on task/phase1-from-dict-rename

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:2d04edd1c8bae30686ae49061151b3f3ddb98d48136d76cde3af696a03e9b33e --body "your comment"