gabriel / muse public
fix BREAKING task/rc13-green-suite-typing-audit #1 / 1
AI Agent gabriel · 18 hours ago · Jun 17, 2026 · Diff

fix: green the muse test suite + typing audit to 0/0 for rc13

Test-suite fixes (stale tests aligned to current behavior): - test_cmd_hub_hardening: proposal IDs shown in full (per the full-cryptographic-ID CLI change), renamed test_proposal_id_truncated_to_8_chars -> _shown_in_full. - test_core_hdkeys: cover all 7 HD domains incl. DOMAIN_GENERIC (was 6). - test_migrate_domain_integers: derive the legacy domain set from OLD_DOMAIN_NAMES (the code's source of truth) instead of a hardcoded range(7); the index-domain migration is deprecated (tracked for removal in muse#38). - watch_coord: print the full uid (not uid_short) in the text branch.

Typing audit -> ratchet 0/0 (code + tests): - Add type JsonObject = dict[str, JsonValue] to muse.core.types (mirrors MsgpackDict). - merge.py / engine.py / merge_debug.py: manifest dicts -> Manifest, JSON dicts -> JsonObject, val: object -> JsonValue, drop unused Any import. - Merge-engine test helpers: manifest -> Manifest, _env -> Metadata, op dicts -> JsonObject; annotate 35 untyped test defs (return types + tmp_path params).

All edits use named aliases so no boundary_dict/bare_dict trade-offs. py_compile clean; typing_audit --max-any 0 --max-untyped 0 exits 0.

sha256:18b2e4a39bc48e1ca2fb0cb24dcdda706fd12d1d83e7fb1c5254c97929e0ad6d sha
sha256:e452ad9a6ace6ccc6d875a35e06caf9da5576a970c1c36133b69a891ce5fefa8 parent
+26 ~91 −4 symbols
17 changed · 1078 in snapshot files
sha256:6e108a7c264954e0a4ac26ca6a9b19b6e98f4003712bf099137605bc47bab1ef snapshot
+26
symbols added
~91
symbols modified
−4
symbols removed
17
files changed
1078
files in snapshot
0
dead code introduced
Semantic Changes 121 symbols
~ muse/cli/commands/merge.py .py 1 symbol added, 4 symbols modified
+ JsonObject import import JsonObject L84–84
~ _build_explain_trace
~ _print_explain_trace
~ _run_merge
~ Manifest
~ muse/cli/commands/watch_coord.py .py 1 symbol modified
~ _emit_event
~ muse/core/harmony/engine.py .py 2 symbols added, 4 symbols modified
+ JsonObject import import JsonObject L75–75
+ JsonValue import import JsonValue L75–75
~ _read_config_float
~ auto_apply
~ Manifest
~ short_id
~ muse/core/merge_debug.py .py 2 symbols added, 1 symbol removed, 2 symbols modified
− Any import import Any L19–19
+ JsonObject import import JsonObject L20–20
+ Manifest import import Manifest L20–20
~ merge_debug_log
~ merge_debug_manifest_summary
~ muse/core/types.py .py 1 symbol added
+ JsonObject variable variable JsonObject L43–43
~ tests/test_cmd_hub_hardening.py .py 1 symbol added, 1 symbol removed, 1 symbol modified
− test_proposal_id_truncated_to_8_chars method method test_proposal_id_truncated_to_8_chars L1907–1914
+ test_proposal_id_shown_in_full method method test_proposal_id_shown_in_full L1907–1915
~ TestFormatProposalVerbose
~ tests/test_core_hdkeys.py .py 1 symbol added, 1 symbol removed, 1 symbol modified
− test_all_6_domains_x_3_entities_x_5_roles_unique method method test_all_6_domains_x_3_entities_x_5_roles_unique L471–485
+ test_all_7_domains_x_3_entities_x_5_roles_unique method method test_all_7_domains_x_3_entities_x_5_roles_unique L471–485
~ TestStress
~ tests/test_migrate_domain_integers.py .py 3 symbols added, 1 symbol removed, 9 symbols modified
− test_build_plans_all_seven_legacy_domains method method test_build_plans_all_seven_legacy_domains L321–331
+ test_build_plans_all_legacy_domains method method test_build_plans_all_legacy_domains L328–338
+ _LEGACY_DOMAINS variable variable _LEGACY_DOMAINS L61–61
+ _OLD_DOMAIN_NAMES import import _OLD_DOMAIN_NAMES L55–55
~ TestIsLegacyHdPath
~ test_all_old_sequential_domains_are_legacy
~ TestMigrationPlan
~ TestPerformance
~ test_is_legacy_hd_path_fast_for_thousand_calls
~ test_run_migration_twenty_entries_under_ten_seconds
~ TestStress
~ test_dry_run_fifty_hubs_no_writes
~ test_live_run_fifty_hubs_all_registered
~ tests/test_phantom_conflicts.py .py 2 symbols added, 5 symbols modified
+ Manifest import import Manifest L13–13
+ Metadata import import Metadata L13–13
~ _checkout
~ _env
~ _make_commit
~ blob_id
~ fake_id
~ tests/test_phase1_merge_engine.py .py 2 symbols added, 11 symbols modified
+ Manifest import import Manifest L20–20
+ Metadata import import Metadata L20–20
~ TestHistoryFlag
~ _clean_merge_repo
~ TestOnConflictFlag
~ _conflicting_repo
~ TestStrategyFlag
~ _two_branch_repo
~ _checkout
~ _env
~ _make_commit
~ blob_id
~ fake_id
~ tests/test_phase2_conflict_granularity.py .py 2 symbols added, 6 symbols modified
+ Manifest import import Manifest L22–22
+ Metadata import import Metadata L22–22
~ _checkout
~ _env
~ _make_commit
~ _merged_snapshot
~ blob_id
~ fake_id
~ tests/test_phase3_strategy_matrix.py .py 2 symbols added, 6 symbols modified
+ Manifest import import Manifest L20–20
+ Metadata import import Metadata L20–20
~ _checkout
~ _env
~ _make_commit
~ _merged_snapshot
~ blob_id
~ fake_id
~ tests/test_phase4_harmony_history.py .py 2 symbols added, 5 symbols modified
+ Manifest import import Manifest L34–34
+ Metadata import import Metadata L34–34
~ _checkout
~ _env
~ _make_commit
~ blob_id
~ fake_id
~ tests/test_phase5_phantom_guard.py .py 1 symbol added, 6 symbols modified
+ JsonObject import import JsonObject L34–34
~ TestOpsCommuteConvergentGuard
~ test_PG_03_replace_same_new_content_id_commutes
~ test_PG_03b_replace_different_new_content_id_conflicts
~ test_PG_03c_replace_different_address_commutes
~ blob_id
~ fake_id
~ tests/test_phase6_unified_merge_engine.py .py 12 symbols modified
~ test_ME_01_three_way_escalate_conflicts
~ test_ME_02_three_way_prefer_ours
~ test_ME_03_three_way_prefer_theirs
~ test_ME_04_snapshot_prefer_theirs
~ test_ME_05_snapshot_escalate
~ test_ME_06_replay_ours
~ test_ME_07_replay_theirs
~ test_ME_08_strategy_map_entries
~ test_ME_09_clean_merge_no_conflicts
~ test_ME_10_musehub_overlay_via_run_merge
~ test_ME_11_musehub_recursive_surfaces_conflicts
~ test_ME_12_musehub_replay_applies_from_delta
~ tests/test_phase7_merge_correctness.py .py 2 symbols added, 4 symbols modified
+ Manifest import import Manifest L53–53
+ Metadata import import Metadata L53–53
~ _env
~ _make_commit
~ blob_id
~ fake_id
~ tests/test_phase8_explain.py .py 2 symbols added, 14 symbols modified
+ Manifest import import Manifest L26–26
+ Metadata import import Metadata L26–26
~ _env
~ _make_commit
~ blob_id
~ fake_id
~ test_EX_01_explain_flag_accepted
~ test_EX_02_explain_dry_run_json_has_explain_key
~ test_EX_03_strategy_routing_fields
~ test_EX_04_conflict_per_path_entry
~ test_EX_05_theirs_only_per_path_entry
~ test_EX_06_convergent_per_path_entry
~ test_EX_07_untouched_per_path_entry
~ test_EX_08_harmony_auto_resolved_in_explain
~ test_EX_09_summary_counts_match_per_path
~ test_EX_10_human_readable_explain_output
Files Changed
~17
1078 in snapshot
~ muse/cli/commands/merge.py .py
~ muse/cli/commands/watch_coord.py .py
~ muse/core/harmony/engine.py .py
~ muse/core/merge_debug.py .py
~ muse/core/types.py .py
~ tests/test_cmd_hub_hardening.py .py
~ tests/test_core_hdkeys.py .py
~ tests/test_migrate_domain_integers.py .py
~ tests/test_phantom_conflicts.py .py
~ tests/test_phase1_merge_engine.py .py
~ tests/test_phase2_conflict_granularity.py .py
~ tests/test_phase3_strategy_matrix.py .py
~ tests/test_phase4_harmony_history.py .py
~ tests/test_phase5_phantom_guard.py .py
~ tests/test_phase6_unified_merge_engine.py .py
~ tests/test_phase7_merge_correctness.py .py
~ tests/test_phase8_explain.py .py
← Older Oldest on task/rc13-green-suite-typing-audit
All commits
Newer → Latest on task/rc13-green-suite-typing-audit

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:18b2e4a39bc48e1ca2fb0cb24dcdda706fd12d1d83e7fb1c5254c97929e0ad6d --body "your comment"